fix: authentication extension packet ordering and Bleak 3.x compatibility

[eman]

Summary

Fixes the bugs surfaced by issue #24 (pump disconnecting after authentication on BLE firmware V06.00.01).

Fix 1: Extension packets sent in wrong order and in parallel

send_extension_packets() used asyncio.TaskGroup to fire both packets concurrently, with EXTEND_2 submitted before EXTEND_1. The packet trace spec requires EXTEND_1 → EXTEND_2 with a 50ms gap. Sending them in parallel causes premature disconnection. Fixed by sending sequentially with await and a 50ms sleep.

Fix 2: Bump minimum Bleak requirement to 3.0

Bleak 3.0 removed the adapter= keyword. Rather than maintain a version-detection shim, the minimum requirement is now bleak>=3.0.0. On Linux, an adapter name is passed via bluez={"adapter": ...}; on other platforms it is ignored. The _make_bleak_client() helper and its tests are removed.

Fix 3: Disconnection guard in read_once()

Added transport.is_connected() checks before the flow/pressure and temperature queries. If the pump disconnects mid-sequence the method now returns partial telemetry instead of raising a BleakError.

Fix 4: SetpointInfo.control_mode type (int → ControlMode | int)

The field was typed as bare int, causing AttributeError when callers accessed .name. Added a field_validator that coerces known values to the ControlMode IntEnum; unknown values remain as int. The service now passes the already-coerced self._current_mode to the constructor.

Fix 5: Double Pa→m conversion for pressure setpoints

ControlService.get_mode() converted pressure setpoints from Pascals to metres before storing in SetpointInfo, but get_display_value() and get_limits_display() then divided by 9806.65 again, producing values ~10,000× too small. Extended the service-side conversion to all pressure modes and removed the redundant division from both model methods.

Changes

File	Change
core/authentication.py	Sequential extension packets, correct order (fix 1)
client.py	Bleak 3.x adapter handling inlined; compat shim removed (fix 2)
services/telemetry.py	Disconnection guard in read_once() (fix 3)
models.py	SetpointInfo.control_mode type + double-conversion fix (fixes 4, 5)
services/control.py	Extend Pa→m conversion to all pressure modes (fix 5)
pyproject.toml	Bump bleak>=3.0.0
scripts/verify_hardware.py	Hardware regression-test script (new)

Hardware verification

Tested on a physical ALPHA HWR running BLE firmware 2811431V06.00.01.00001 (the firmware reported in #24) using Bleak 3.0.2 and Python 3.14.5:

• Authentication completes without disconnection
• control_mode.name resolves to TEMPERATURE_RANGE_CONTROL
• get_display_value() returns 36.00 °C
• Telemetry flow_m3h and head_m are populated

Closes #24

[Copilot]

Pull request overview

This PR addresses a BLE firmware-specific authentication regression (issue #24) by enforcing correct extension packet sequencing/timing, adds compatibility for Bleak 3.x’s adapter= deprecation, and makes telemetry reads more resilient to mid-sequence disconnects.

Changes:

• Send authentication extension packets sequentially (EXTEND_1 → 50ms → EXTEND_2) instead of concurrently/out-of-order.
• Add _make_bleak_client() to select BleakClient kwargs compatible with Bleak 2.x vs 3.x (adapter= vs bluez={...} on Linux).
• Return partial telemetry from TelemetryService.read_once() when a disconnect is detected mid-read.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
src/alpha_hwr/core/authentication.py	Enforces correct extension packet ordering/timing; updates embedded pseudocode accordingly.
src/alpha_hwr/client.py	Introduces Bleak client factory for Bleak 3.x adapter= deprecation handling.
src/alpha_hwr/services/telemetry.py	Adds connection-state guards to return partial telemetry instead of raising after disconnects.
pyproject.toml	Notes Bleak 3.x support in dependency comment.

Comments suppressed due to low confidence (1)

src/alpha_hwr/services/telemetry.py:284

• New behavior: if the pump disconnects before the temperature query, read_once() returns the partial telemetry rather than attempting the query. Please add a unit test covering this path (transport.is_connected() -> False) to ensure the early-return behavior is preserved.

        # 3. Query Temperatures (always poll)
        if not self.transport.is_connected():
            logger.debug("Pump disconnected before temperature query")
            return self._telemetry

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.