Add connection timeout configuration to ConfigurationParameters#44
Open
konard wants to merge 3 commits intoemailage:masterfrom
Open
Add connection timeout configuration to ConfigurationParameters#44konard wants to merge 3 commits intoemailage:masterfrom
konard wants to merge 3 commits intoemailage:masterfrom
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: emailage#41
This adds the ability to configure connectTimeout and readTimeout for HTTP connections on a per-request basis through ConfigurationParameters, solving the issue where timeouts could only be set by overwriting the global static httpHelper instance. Changes: - Add connectTimeout and readTimeout fields to ConfigurationParameters - Add overloaded getHttpsURLConnection method in HttpHelper that accepts timeout params - Pass timeout configuration through OAuth1 and OAuth2 request flows - Add unit tests for timeout configuration Fixes emailage#41 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit 9806992.
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to configure
connectTimeoutandreadTimeoutfor HTTP connections on a per-request basis throughConfigurationParameters. This solves issue #41 where timeouts could only be set by overwriting the global statichttpHelperinstance.Changes
connectTimeoutandreadTimeoutfields toConfigurationParameterswith getters/settersgetHttpsURLConnection(URL url, Integer connectTimeout, Integer readTimeout)method inHttpHelperEmailageClientOAuth2Wrapper.doOAuth2Request()andgetAccessToken()to accept timeout parametersUsage Example
Test plan
Note: Some pre-existing tests fail due to Java 21 incompatibility with JaCoCo 0.8.6 and PowerMock (module access restrictions). This is an environmental issue unrelated to these changes.
Fixes #41
🤖 Generated with Claude Code