Repository navigation
Rounding fix - #457
Open
spiregarden wants to merge 3 commits into
Open
Rounding fix#457spiregarden wants to merge 3 commits into
spiregarden wants to merge 3 commits into
Conversation
Co-authored-by: spiregarden <79320948+spiregarden@users.noreply.github.com>
Finalize invoice totals rounding in PHP instead of XPath
spiregarden
marked this pull request as ready for review
October 27, 2026 06:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still experienced the rounding error on 2.4.2: The operator bounces some invoices with:
"InvoiceNo 12345678: Checking LegalTotal gave a difference that is too large. -0,01 > 0,005 InvoiceNo 12345678: Total amount is not correct: Total excluding VAT + VAT + rounding amount <> Total including VAT InvoiceNo 12345678: Total amount of invoice is incorrect.:135,00 + 34,42 + 0,00 <> 169,43 (0,01) InvoiceNo 12345678: Invoice validation failed"
Disclaimer: This fix was implemented with AI-assistance, so feel free to reject.
The real world testing is quite limited so far, so I recommend waiting a couple of months before merging.