Skip to content

#80 Update deprecated functions - #81

Merged
Museus merged 2 commits into
ellomenop:main-nextfrom
Kenorah:#80-Update-Deprecated-Functions
Nov 14, 2022
Merged

#80 Update deprecated functions#81
Museus merged 2 commits into
ellomenop:main-nextfrom
Kenorah:#80-Update-Deprecated-Functions

Conversation

@Kenorah

@Kenorah Kenorah commented Oct 29, 2022

Copy link
Copy Markdown

To be pulled after #71 has been pulled

@Kenorah

Kenorah commented Oct 29, 2022

Copy link
Copy Markdown
Author

ModUtil.MapSetTable(RoomSetData.Styx.D_MiniBoss03, {
ModUtil.Table.Merge(RoomSetData.Styx.D_MiniBoss03, {
LegalEncounters = { "MiniBossCrawler", "MiniBossHeavyRangedForked" },
})

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed one indent but not the other :(

@Museus

Museus commented Oct 30, 2022

Copy link
Copy Markdown
Collaborator

Would prefer the commit messages to follow Conventional Commits, not that I've posted that anywhere.

https://www.conventionalcommits.org/en/v1.0.0/
https://github.com/pvdlg/conventional-commit-types

For this one it'd be something like refactor(deprecated): update ModUtil calls to newest version but it's really up to interpretation.

You can use git rebase -i HEAD~2 if you want to reword the message

@Kenorah
Kenorah force-pushed the #80-Update-Deprecated-Functions branch from e7372e7 to 4aefe8a Compare October 30, 2022 18:17
@Kenorah Kenorah changed the title #80 update deprecated functions #80 Update deprecated functions Oct 30, 2022
@Museus
Museus merged commit aea5d3f into ellomenop:main-next Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants