Repository navigation
chore: Allow Nx 1.0 - #42
Merged
Merged
Conversation
Widens the optional nx requirement to ~> 0.4 or ~> 1.0. The Nx.LazyContainer template now carries the height, width and channels axis names that to_nx/2 sets, so an image passed through a jitted function comes out with the same names as to_nx, which Nx 1.0's tensor equality checks.
Nx 1.0 needs Elixir 1.17, so the test and precompile jobs move from 1.13/1.15 on OTP 24/26 to 1.17 on OTP 25/27. Precompiling on OTP 25 still covers OTP 24 users since both are NIF 2.16.
cocoa-xu
approved these changes
Sep 15, 2026
cocoa-xu
reviewed
Sep 15, 2026
ubuntu-20.04 and macos-13 runners are gone, so the jobs never start. The Linux job now runs on ubuntu-latest inside an ubuntu:20.04 container to keep the old glibc, and macOS moves to macos-15-intel.
cocoa-xu
reviewed
Sep 15, 2026
Contributor
|
CI is still failing. Im guessing we don't have old enough versions for beam-setup as well. It is probably fine to dump ubuntu-20 though? @cocoa-xu also, shall we release v1.0 of this library? |
erlef/setup-beam refuses to run in a container it doesn't recognize, so both Linux jobs now use the elixir-lang.org install script, which pulls the ubuntu-20.04 builds from builds.hex.pm. precompile.yml gets the same container and macos-15-intel.
cocoa-xu
reviewed
Sep 15, 2026
Member
I do😛, I have almost all versions from OTP 23 on https://github.com/cocoa-xu/otp-build
lets do that! |
Member
Author
|
🤘 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nx 1.0.0 is out and the optional
nx ~> 0.4keeps it out of the resolver for anyone with both stb_image and Nx 1.0 in a project. Scholar hits this through scidata. This widens it to~> 0.4 or ~> 1.0and moves the lock to 1.0.0.One real change: the
Nx.LazyContainertemplate didn't carry theheight,width,channelsaxis names thatto_nx/2sets, so an image going through a jitted function came out unnamed. Nx 1.0 compares names in tensor equality and the lazy container test caught it. The template now has the names.CI moves to Elixir 1.17, Nx 1.0's floor, on OTP 25 and 27. Precompiling on OTP 25 still covers OTP 24 since both are NIF 2.16.