fix(mint): return raw connect errors, not strings - #584
Open
arrangabriel wants to merge 3 commits into
Open
Conversation
arrangabriel
force-pushed
the
keep-mint-transport-errors
branch
from
September 1, 2026 07:26
4c433b1 to
b3d9196
Compare
arrangabriel
force-pushed
the
keep-mint-transport-errors
branch
from
September 1, 2026 07:26
b3d9196 to
932e16b
Compare
sleipnir
approved these changes
Sep 1, 2026
Collaborator
|
@arrangabriel you can take a look on failures? Error: test/grpc/integration/stub_test.exs:96
Assertion failed, no matching message after 100ms
The process mailbox is empty.
code: assert_receive {:initial_call_succeeded, initial_channel, "Hello, first caller"}
stacktrace:
test/grpc/integration/stub_test.exs:109: anonymous fn/1 in GRPC.Integration.StubTest."test named Gun connections survive the original caller exiting"/1
(grpc 1.0.5) test/support/integration_data_case.ex:47: GRPC.Integration.TestCase.run_server/4
test/grpc/integration/stub_test.exs:97: (test) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return Mint connect failure reason, not a formatted string
Currently,
connect/2inspects whateverConnectionProcess.start_link/4returns into a message, so a refused connection results in:{:error, "Error while opening connection: {:error, %Mint.TransportError{reason: :econnrefused}}"}. This is hard for callers to use, e.g. in a case expression. The Gun adapter returns transport errors directly.Changes
connect/2and its catch :exit clause return the error tuple directly.