fix(mint): explicitly support infinite retries - #579
Open
arrangabriel wants to merge 1 commit into
Open
Conversation
arrangabriel
force-pushed
the
feat/mint-infinite-retry
branch
from
August 28, 2026 06:00
976ac11 to
40bd8d4
Compare
arrangabriel
force-pushed
the
feat/mint-infinite-retry
branch
from
September 1, 2026 06:01
40bd8d4 to
a22b64c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly support
retry: :infinityin the Mint adapterThe option already worked, because atoms are above integers in erlang term ordering.
This behavior was undocumented, and arguably supported only by accident.
Changes
Heads-up for downstream test suites
Mox generates optional callbacks on mocks, so an existing Mox.defmock for
GRPC.Client.Adapter will export validate_opts/1 and raise
UnexpectedCallError unless it is stubbed. Adapters using the behaviour without
defining validate_opts/1 are fine.