Issue 83: Prevent "#{}" expansion in literal heredocs#104
Open
mshenfield wants to merge 1 commit intoelixir-editors:masterfrom
Open
Issue 83: Prevent "#{}" expansion in literal heredocs#104mshenfield wants to merge 1 commit intoelixir-editors:masterfrom
mshenfield wants to merge 1 commit intoelixir-editors:masterfrom
Conversation
The atom-brackets package is configured to expand "#" into "#{$1}" in `comment.documentation.heredoc.elixir` contexts. To avoid this and close elixir-editors#83, this changes literal heredoc contexts (`~S`) to have a more specific tag, `comment.documentation.heredoc.literal.elixir`.
Tested by `apm link`ing the modified `language-elixir` locally and confirmed that "#" no longer expanded in literal heredocs. Also modified existing tests to expect the new name where appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atom-brackets package is configured to expand "#" into "#{$1}" in
comment.documentation.heredoc.elixircontexts. To avoid this and close #83, this changes literal heredoc contexts (~S) to have a more specific tag,comment.documentation.heredoc.literal.elixir.Tested by
apm linking the modifiedlanguage-elixirlocally and confirmed that "#" no longer expanded in literal heredocs. Also modified existing tests to expect the new name where appropriate.