Skip to content

Added total evictions in live stats component and total request in slab. Fix for issue #37 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arunk2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added total evictions in live stats component and total request in slab. Fix for issue #37 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Library/Data/Analysis.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ public static function slabs($slabs)
$slabs['used_slabs'] ++;
}
$slabs[$id]['request_rate'] = sprintf('%.1f', ($slab['get_hits'] + $slab['cmd_set'] + $slab['delete_hits'] + $slab['cas_hits'] + $slab['cas_badval'] + $slab['incr_hits'] + $slab['decr_hits']) / $slabs['uptime'], 1);
$slabs[$id]['request_count'] = sprintf('%.1f', ($slab['get_hits'] + $slab['cmd_set'] + $slab['delete_hits'] + $slab['cas_hits'] + $slab['cas_badval'] + $slab['incr_hits'] + $slab['decr_hits']), 1);
$slabs[$id]['mem_wasted'] = (($slab['total_chunks'] * $slab['chunk_size']) < $slab['mem_requested']) ? (($slab['total_chunks'] - $slab['used_chunks']) * $slab['chunk_size']) : (($slab['total_chunks'] * $slab['chunk_size']) - $slab['mem_requested']);
$slabs['total_wasted'] += $slabs[$id]['mem_wasted'];
}
Expand Down Expand Up @@ -324,4 +325,4 @@ public static function hitResize($value)
}
return sprintf('%.0f%s', $value, $unit);
}
}
}
4 changes: 4 additions & 0 deletions View/LiveStats/Frame.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@
</div>
<div class="line">
<span class="left setting">EVI/s</span>
Number of times an item which had an explicit expire time set had to be evicted before it expired per second
</div>
<div class="line">
<span class="left setting">EVIs</span>
Number of times an item which had an explicit expire time set had to be evicted before it expired
</div>
<div class="line">
Expand Down
7 changes: 4 additions & 3 deletions View/LiveStats/Stats.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ define('EOL', "\r\n");
echo 'Last update : ' . date('r', time()) . ' (refresh rate : ' . $_ini->get('refresh_rate') . ' sec)' . EOL . EOL;

# Table header
echo '<strong>' . sprintf('%-36s', 'NAME') . sprintf('%10s', 'SIZE') . sprintf('%7s', '%MEM') . sprintf('%8s', 'TIME') .
echo '<strong>' . sprintf('%-30s', 'NAME') . sprintf('%10s', 'SIZE') . sprintf('%7s', '%MEM') . sprintf('%8s', 'TIME') .
sprintf('%6s', 'CONN') . sprintf('%7s', '%HIT') . sprintf('%8s', 'REQ/s') . sprintf('%8s', 'GET/s') . sprintf('%8s', 'SET/s') .
sprintf('%8s', 'DEL/s') . sprintf('%8s', 'EVI/s') . sprintf('%11s', 'READ/s') . sprintf('%10s', 'WRITE/s') . '</strong>' . EOL . '<hr>';
sprintf('%8s', 'DEL/s') . sprintf('%8s', 'EVI/s') . sprintf('%6s', 'EVIs') . sprintf('%11s', 'READ/s') . sprintf('%10s', 'WRITE/s') . '</strong>' . EOL . '<hr>';

# Showing stats for every server
foreach($stats as $server => $data)
{
# Server name
echo sprintf('%-36.36s', $server);
echo sprintf('%-30.36s', $server);

# Checking for stats validity
if((isset($data['time'], $data['bytes_percent'], $data['get_hits_percent'], $data['query_time'], $data['request_rate'], $data['curr_connections'],
Expand Down Expand Up @@ -70,6 +70,7 @@ foreach($stats as $server => $data)
{
echo sprintf('%8s', Library_Data_Analysis::valueResize($data['eviction_rate']));
}
echo sprintf('%6.0f', Library_Data_Analysis::valueResize($data['evictions']));

# Bytes read
echo sprintf('%11s', Library_Data_Analysis::byteResize($data['bytes_read'] / $data['time']) . 'b');
Expand Down
4 changes: 4 additions & 0 deletions View/Stats/Slabs.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ foreach($slabs as $id => $slab)
<span class="left slabs">Hits</span>
<?php echo ($slab['request_rate'] > 999) ? Library_Data_Analysis::hitResize($slab['request_rate']) : $slab['request_rate']; ?> Request/sec
</div>
<div class="line">
<span class="left slabs">Total Reqs</span>
<?php echo Library_Data_Analysis::hitResize($slab['request_count']); ?>
</div>
<?php
if($slab['used_chunks'] > 0)
{ ?>
Expand Down