Skip to content
This repository was archived by the owner on Jun 6, 2021. It is now read-only.

csv comma separted values ==> ";"#17

Open
mikadev wants to merge 6 commits into
elidickinson:masterfrom
mikadev:patch-1
Open

csv comma separted values ==> ";"#17
mikadev wants to merge 6 commits into
elidickinson:masterfrom
mikadev:patch-1

Conversation

@mikadev

@mikadev mikadev commented Jul 22, 2015

Copy link
Copy Markdown

At 129 the separator is wrong so i added a parameter with default values

At 129 the separator is wrong so i added a parameter with default values
@elidickinson

Copy link
Copy Markdown
Owner

I'm not sure I understand. "," is a comma and ";" is a semicolon. I'm fine with adding semicolon as an optional delimiter, but is there a reason you prefer it over the more common comma?

@mikadev

mikadev commented Jul 22, 2015

Copy link
Copy Markdown
Author

you ever try export csv with your separator and open it ? the result is completly weird.
and is the default separator you can try with save as csv.

@elidickinson

Copy link
Copy Markdown
Owner

Opening it in Excel, you mean? Weird how?

My intent is that exporting to CSV should produce a file that looks as close to "official" CSV format as is possible, not just what works best with Excel. Also, my Excel Mac 2011 exports with commas not semicolons by default when doing "save as..."

@mikadev

mikadev commented Jul 23, 2015

Copy link
Copy Markdown
Author

it depends on the country for exemple in france the default separator is the semicolon so i propose you to add an optional parameter with default value ==> ","

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants