Skip to content

[DX-1319] Generalize type-surface check to the packages matrix - #918

Draft
kraenhansen wants to merge 2 commits into
kh/dx-1319-dts-breaking-changesfrom
kh/dx-1319-packages-type-surface
Draft

[DX-1319] Generalize type-surface check to the packages matrix#918
kraenhansen wants to merge 2 commits into
kh/dx-1319-dts-breaking-changesfrom
kh/dx-1319-packages-type-surface

Conversation

@kraenhansen

@kraenhansen kraenhansen commented Aug 6, 2026

Copy link
Copy Markdown
Member

Stacked on #917 (base is that branch, not main).

Adds the type surface workflow that checks every package's public type surface on a PR and reports them in a single comment. The engine, discovery, and action live in #917.

How

  • Builds head and the merge-base (via git worktree) once with turbo.
  • Detects pending major changesets and passes them as allow-breaking-packages.
  • Runs ./.github/actions/dts-breaking-changes in workspace mode (base-root/head-root): the action discovers each package's public type entrypoints and reports them in one PR comment. A consumer-breaking change fails the check unless acknowledged by the breaking label or a major changeset for that package.
  • @elevenlabs/types is type-only, so it ships dts-breaking-changes.json with compareTypeOnlyExports: true.

Test plan

  • Posts one combined comment; discovery covers all public entrypoints (incl. @elevenlabs/client's ././internal/./internal/unity and @elevenlabs/react-native)
  • A breaking change in one package shows red in that section only; a major changeset (or the breaking label) turns it to a warning

🤖 Generated with Claude Code

@kraenhansen
kraenhansen force-pushed the kh/dx-1319-packages-type-surface branch from 6fec5ff to c762fe7 Compare August 6, 2026 13:52
@elevenlabs elevenlabs deleted a comment from github-actions Bot Aug 6, 2026
@elevenlabs elevenlabs deleted a comment from github-actions Bot Aug 6, 2026
@elevenlabs elevenlabs deleted a comment from github-actions Bot Aug 6, 2026
@elevenlabs elevenlabs deleted a comment from github-actions Bot Aug 6, 2026
@kraenhansen
kraenhansen force-pushed the kh/dx-1319-packages-type-surface branch from c762fe7 to f7e9fb7 Compare August 6, 2026 14:00
@kraenhansen
kraenhansen force-pushed the kh/dx-1319-packages-type-surface branch 2 times, most recently from 228f84b to 838dc43 Compare August 6, 2026 14:44
@kraenhansen
kraenhansen force-pushed the kh/dx-1319-packages-type-surface branch from 838dc43 to d07f773 Compare August 6, 2026 14:54
@kraenhansen
kraenhansen force-pushed the kh/dx-1319-packages-type-surface branch 6 times, most recently from cd13430 to 490687b Compare August 7, 2026 11:19
@elevenlabs elevenlabs deleted a comment from github-actions Bot Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Type surface report

✅ No type-surface changes across 5 package(s).

Unchanged: @elevenlabs/client (., ./internal, ./internal/unity), @elevenlabs/convai-widget-core (.), @elevenlabs/react (.), @elevenlabs/react-native (., . (react-native)), @elevenlabs/types (.).
Compared against base 3736a3d · Generated by the type surface workflow.

kraenhansen and others added 2 commits August 7, 2026 13:25
Single job that builds head and the merge-base (git worktree) once with turbo,
then runs the dts-breaking-changes action in workspace mode: the action
discovers every package's public type entrypoints and reports them in one PR
comment. Major changesets are detected and passed as `allow-breaking-packages`.

`@elevenlabs/types` is type-only, so it ships dts-breaking-changes.json with
`compareTypeOnlyExports: true`.

The engine, discovery, and multi-surface action live in the base PR (#917).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Turn on `api-summary` so each packages PR renders a structural diff of
API additions/removals/changes alongside the breaking-change gate. It is
a review aid only and does not affect the gate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kraenhansen
kraenhansen force-pushed the kh/dx-1319-packages-type-surface branch from 490687b to b93ac32 Compare August 7, 2026 11:25
@kraenhansen kraenhansen self-assigned this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant