Skip to content

Fix scrubbing - #729

Draft
lenemter wants to merge 1 commit into
mainfrom
lenemter/fix-scrubbing
Draft

Fix scrubbing#729
lenemter wants to merge 1 commit into
mainfrom
lenemter/fix-scrubbing

Conversation

@lenemter

@lenemter lenemter commented Sep 14, 2026

Copy link
Copy Markdown
Member

Closes #721

Changes:

  • Use pointing_to instead of reparanting the popover
  • Remove unintuitive behaviour where setting current_indicator to the opened indicator toggled it

@lenemter
lenemter requested a review from a team September 14, 2026 17:43
@lenemter
lenemter force-pushed the lenemter/fix-scrubbing branch from 8a67ae0 to 922510e Compare September 14, 2026 17:45
danirabbit
danirabbit reviewed Sep 14, 2026
View reviewed changes

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason with the branch the only indicator that will open now is notifications

Comment thread src/Services/PopoverManager.vala Outdated
@lenemter
lenemter force-pushed the lenemter/fix-scrubbing branch from 922510e to cb5737f Compare September 14, 2026 19:17
@lenemter
lenemter marked this pull request as draft September 18, 2026 18:40
@lenemter
lenemter force-pushed the lenemter/fix-scrubbing branch from cb5737f to 0b3edfa Compare September 19, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danirabbit danirabbit danirabbit left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lenemter @danirabbit