Introduce KeybindingHelper - #713
Merged
Merged
Conversation
lenemter
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model it after
Meta.Display.add_keybindingin mutter. This allows to easily add keybindings and takes care of resetting grabs when the settings change etc. This is done because we use it in quite a few indicators and wingpanel itself so IMO it makes sense to have a convenient api to do this.This can be and is used now by wingpanel itself for the notifications action. It can also be used in the sound indicator for the media keys and will be used in the power indicator for the brightness media keys.
For the activation a
KeybindingActionis introduced with several subclasses. I modeled this after Gtk.ShortcutAction because it is convenient to use and allows us to avoid memory leaks while keeping the internals private.