Skip to content

Popover: remove arrow, rounder, margins - #703

Merged
danirabbit merged 2 commits into
mainfrom
danirabbit/popover-no-arrow
Aug 28, 2026
Merged

danirabbit merged 2 commits into
mainfrom
danirabbit/popover-no-arrow

Conversation

@danirabbit

Copy link
Copy Markdown
Member
Screenshot from 2026-08-27 18 07 18 Screenshot from 2026-08-27 18 07 30

@danirabbit
danirabbit requested a review from a team August 28, 2026 01:09
@kurisubrooks

Copy link
Copy Markdown
Member

I think my main point of contention is that if the arrow is removed, we need to signify that this popover is connected to X icon/panel item in another way.

Currently there's no active state for wingpanel items when a popover is open, so it just looks like another floating window with no relation to the content it opens from.

I also can't remember off the top of my head if we currently animate the popover contents, but adding a fade in + down animation to the popover would also help anchor the content to the panel item were the arrow removed.

@kurisubrooks

This comment was marked as resolved.

@danirabbit

Copy link
Copy Markdown
Member Author

@kurisubrooks animating the popover will take some more time, but how is it now with the checked state?

@kurisubrooks

Copy link
Copy Markdown
Member

@kurisubrooks animating the popover will take some more time, but how is it now with the checked state?

I think the animation can be handled in a follow-up. With the :checked state, it should be sufficient for now. Did you want me to spin it off into an issue?

@danirabbit danirabbit added this to OS 9 Aug 28, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Aug 28, 2026

@kurisubrooks kurisubrooks left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a follow-up issue for the animation, so this isn't blocked. Thanks 👍🏻

Edit: tracked in #705

@danirabbit
danirabbit merged commit 38f899b into main Aug 28, 2026
4 of 6 checks passed
@danirabbit
danirabbit deleted the danirabbit/popover-no-arrow branch August 28, 2026 02:46
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants