Skip to content

UserSettingsView: use switch for locking account - #259

Merged
ryonakano merged 13 commits into
mainfrom
danirabbit/usersettingsview-disableswitch
Sep 12, 2026
Merged

ryonakano merged 13 commits into
mainfrom
danirabbit/usersettingsview-disableswitch

Conversation

@danirabbit

@danirabbit danirabbit commented Sep 21, 2025

Copy link
Copy Markdown
Member

Can be rebase merged if desired

  • Uses an action to manage account lock state and sensitivity
  • Uses a switch instead of a text button in line with other settings panes
  • Change primary tooltip text to be state agnostic. Avoids a situation where it reads "Disable Account checkbox checked" which is pretty difficult to figure out whether that means the account is disabled or not
  • Make sure we use accurate secondary tooltip text
Screenshot from 2025-09-21 12 01 26

@danirabbit
danirabbit requested a review from a team September 21, 2025 19:02
@danirabbit danirabbit added this to OS 9 Sep 21, 2025
@danirabbit danirabbit moved this to Needs Review in OS 9 Sep 21, 2025
Comment thread src/Views/UserSettingsView.vala Outdated
Comment thread src/Views/UserSettingsView.vala Outdated
@danirabbit danirabbit removed this from OS 9 Dec 7, 2025
@danirabbit danirabbit moved this to Needs review in OS 8.1.1 Dec 7, 2025
@danirabbit danirabbit added this to OS 9 Jan 26, 2026
@danirabbit danirabbit removed this from OS 8.1.1 Jan 26, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Jan 26, 2026
@zeebok

zeebok commented Apr 1, 2026

Copy link
Copy Markdown

Do you think the enable switch should be more aligned with the username field?

Comment thread src/Views/UserSettingsView.vala Outdated
@ryonakano
ryonakano merged commit cc90225 into main Sep 12, 2026
4 checks passed
@ryonakano
ryonakano deleted the danirabbit/usersettingsview-disableswitch branch September 12, 2026 06:19
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants