Repository navigation
Preview: Set locale back when completed - #249
Merged
Merged
Conversation
vjr
approved these changes
Aug 23, 2026
vjr
left a comment
Member
There was a problem hiding this comment.
Code looks good, fixes the issue for me with English, India region and format, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
This issue is because
reload_languages ()callsIntl.setlocale (), which affects the execution of all locale-sensitive C library functions as written in valadoc:W call
Gnome.Languages.get_country_from_locale ()inreload_formats ()to construct the formats dropdown, and we pass null as the second parametertranslation.Gnome.Languages.get_country_from_locale ()callssetlocale()to retrieve the current value ofLC_MESSAGESiftranslationis null. Here,LC_MESSAGESis affected byIntl.setlocale ()inreload_languages ().