Remove flatpak apps installed via flatpak preinstall

[ryonakano]

Part of elementary/os#783
Goes after elementary/default-settings#364

[danirabbit]

I'd like to go ahead and merge this because it's blocking mkosi images.

It sounds like it's possible we can also build non-atomic builds with mkosi, so we might not need the default settings branch either way

[ryonakano]

@danirabbit

It sounds like it's possible we can also build non-atomic builds with mkosi, so we might not need the default settings branch either way

I personally think we may want to use the default-settings to keep the preinstall conf file instead of relying on mkosi, at least for now. It's not yet decided that we switch from live-build to mkosi on OS 9, so I'm concerning that premising mkosi at this time could be a risk if mkosi image were to be postponed for further major releases. And if mkosi image is surely land on OS 9 then we can revisit if the preinstall conf file should be the os repository instead of default-settings.

What do you think?

[danirabbit]

@ryonakano I think maybe it would be better to put it in the OS repo for livebuild so that we're not breaking/blocking mkosi builds? Or I'm not sure if we can put it in default settings for both?

@jumpyvi any thoughts?

[ryonakano]

@jumpyvi I'm still not familiar with mkosk so I'm not sure whether we should have separated preinstall files for live-build and mkosk branches (probably results the same content), or we can just put it in the default-settings repository. What do you think?

[ryonakano]

Looks like you created a dedicated systemd service in the mkosi branch, so probably we should maintain in the default-settings repository so as not to have duplicated works?

[jumpyvi]

Looks like you created a dedicated systemd service in the mkosi branch, so probably we should maintain in the default-settings repository so as not to have duplicated works?

Yes, I think it would be fine default-settings.

But yeah, include the systemd script.
Flatpak-preinstall doesn't have one.

[ryonakano]

@jumpyvi I imported your systemd service file into default-settings in the following PRs:

• Use flatpak preinstall for system Flatpak apps default-settings#364
• deb-packaging: Changes for flatpak-preinstall default-settings#367

[jumpyvi]

@jumpyvi I imported your systemd service file into default-settings in the following PRs:

• Use flatpak preinstall for system Flatpak apps default-settings#364
• deb-packaging: Changes for flatpak-preinstall default-settings#367

@ryonakano

Should this be included package-side too?
Without it, preinstall won't work

https://github.com/jumpyvi/elementary-atomic-os/blob/00571ee5e2cc0c9f4ec53f7c810074e04b5e6061/mkosi.extra/usr/share/flatpak/remotes.d/appcenter.flatpakrepo#L4

[ryonakano]

Hmm it worked for me without it 🤔

[jumpyvi]

Hmm it worked for me without it 🤔

There might be some other package that provides the repo.

[ryonakano]

@jumpyvi OK, I think we don't need to provide /usr/share/flatpak/remotes.d/*.flatpakrepo since we install /var/lib/flatpak/repo/config in default-settings ¹.

Latest branch of default-settings just installs the config file to /etc/skel/.local/share/flatpak/repo/config which is for per-user installation, but it does also install to /var/lib/flatpak/repo/config once elementary/default-settings#364 is merged, so it should work without the *.flatpakrepo files.

Footnotes

1. According to man flatpak-remote, /var/lib/flatpak/repo/config is the main configuration file and /usr/share/flatpak/remotes.d/*.flatpakrepo are fragment configuration file for it. ↩