patch: fix screenshot crashing when image height exceeds width enough - #317
Merged
danirabbit merged 1 commit intoAug 20, 2025
Merged
Conversation
Closes #316. ## Description This addresses the issue discussed in issue #316. To summarize what is in that issue, when taking a screenshot and the height is 1/4x or more greater than the width (approx), it will segfault. Two solutions were found, but the simplest was in this PR, which is setting a default window height. The other was to use a deprecated method (which is shown in the issue).
Tbusk
changed the title
danirabbit
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #316.
Description
This addresses the issue discussed in issue #316. To summarize what is in that issue, when taking a screenshot and the height is 1/4x or more greater than the width (approx), it will segfault with my setup.
Two solutions were found, but the simplest was in this PR, which is setting a default window height. The other was to use a deprecated method (which is shown in the issue).
As proof of the fix, here is a screenshot whose dimensions will crash the pre-fix app: