Skip to content

Location dialog suggestion #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 2 commits into from
Aug 1, 2026
Merged

Location dialog suggestion #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c75506
Fix misplaced comment
ryonakano Aug 1, 2026
c95fb2b
Fix unintentional diff
ryonakano Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Access/Portal.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ public class Access.Portal : Object {
};

if ("icon" in options) {
// elementary HIG use non-symbolic icon, while portals ask for symbolic ones.
var icon = options["icon"].get_string ().replace ("-symbolic", "");
if (icon == "find-location") {
dialog = new LocationDialog (app_id) {
parent_handle = parent_window
};
} else {
// elementary HIG use non-symbolic icon, while portals ask for symbolic ones.
dialog.secondary_icon = new ThemedIcon (icon);
}
}
Expand Down Expand Up @@ -66,9 +66,6 @@ public class Access.Portal : Object {
dialog.allow_label = options["grant_label"].get_string ();
}

var _results = new HashTable<string, Variant> (str_hash, str_equal);
uint32 _response = 2;

if ("choices" in options) {
var choices_iter = options["choices"].iterator ();
Variant choice_variant;
Expand All @@ -78,6 +75,9 @@ public class Access.Portal : Object {
}
}

var _results = new HashTable<string, Variant> (str_hash, str_equal);
uint32 _response = 2;

dialog.response.connect ((response) => {
switch (response) {
case ALLOW:
Expand Down