DeviceManagerWidget: connect to list row activated - #327
Merged
Merged
Conversation
Member
Author
|
@flodavid sent you an invite to elementary desktop devs :) I think this is probably the more proper solution |
stsdc
approved these changes
May 22, 2026
flodavid
reviewed
May 22, 2026
Comment on lines
76
to
79
| device_item.activated.connect (() => { | ||
| pam.set_default_device.begin (device); | ||
| update_preferred_devices (device); | ||
| }); |
Contributor
There was a problem hiding this comment.
is this not redundant now ? Maybe it is useful for keyboard navigation or something
Member
Author
There was a problem hiding this comment.
In gtk4 it's easy to make the radio button invisible to clicks but if we remove it now then the radio button will capture clicks and the list item won't be activated
Contributor
|
Indeed this seems to be a better solution. I tested it and it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326
Make sure activating the list item changes the device selection