Port to GTK4 - #295
Merged
Merged
Port to GTK4#295
Conversation
* Fix build failing when defining signals with Gdk.ScrollEvent
I suspect this is a bug of Vala. It tries to call gdk_value_get_event() which
does not exist and fails to build with the following error message:
../src/Widgets/DisplayWidget.vala: In function ‘g_cclosure_user_marshal_VOID__GDK_EVENT’:
../src/Widgets/DisplayWidget.vala:18:19: error: implicit declaration of function ‘gdk_value_get_event’; did you mean ‘g_value_get_uint’? [-Wimplicit-function-declaration]
18 | public class Sound.DisplayWidget : Gtk.Box {
| ^~~~~~~~~~~~~~~~~~~
| g_value_get_uint
../src/Widgets/DisplayWidget.vala:18:19: error: passing argument 2 of ‘callback’ makes pointer from integer without a cast [-Wint-conversion]
18 | public class Sound.DisplayWidget : Gtk.Box {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
This commit resolves the above build error by wrapping Gdk.ScrollEvent with
GLib.Value.
* Make sure scroll works
* Review variable name
* Improve comment
ryonakano
reviewed
Jul 29, 2026
ryonakano
left a comment
ryonakano
left a comment
Member
There was a problem hiding this comment.
Just a quick look but leaving some comments.
danirabbit
marked this pull request as ready for review
August 19, 2026 16:57
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Member
Author
|
@ryonakano did we want to try to migrate to new controllers in this branch or is that okay to leave until after merging? |
Member
|
@danirabbit I think we can merge this with the legacy one for now to introduce the sound indicator to OS 9 Daily. |
ryonakano
approved these changes
Aug 19, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.