Skip to content

NotificationsList: invalidate section sort when a new apptime is set #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 3 commits into from
Sep 4, 2026
Merged

NotificationsList: invalidate section sort when a new apptime is set #339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b848e0
NotificationsList: invalidate section sort when a new apptime is set
danirabbit Sep 3, 2026
93642ba
oopsie with model access
danirabbit Sep 3, 2026
a1a7259
Merge branch 'main' into danirabbit/notificationslist-fixsort
danirabbit Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Widgets/NotificationsList.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public class Notifications.NotificationsList : Granite.Bin {
}
}

private Gtk.SortListModel sort_list_model;
private Gtk.Stack stack;

construct {
Expand All @@ -36,7 +37,7 @@ public class Notifications.NotificationsList : Granite.Bin {

list_store = new GLib.ListStore (typeof (Notification));

var sort_list_model = new Gtk.SortListModel (list_store, new Gtk.CustomSorter ((GLib.CompareDataFunc<GLib.Object>) Notification.compare)) {
sort_list_model = new Gtk.SortListModel (list_store, new Gtk.CustomSorter ((GLib.CompareDataFunc<GLib.Object>) Notification.compare)) {
section_sorter = new Gtk.CustomSorter ((GLib.CompareDataFunc<GLib.Object>) section_func)
};

Expand Down Expand Up @@ -116,6 +117,7 @@ public class Notifications.NotificationsList : Granite.Bin {
unowned GLib.DateTime? time = app_datetime[notification.desktop_id];
if (time == null || time.compare (notification.timestamp) <= 0) {
app_datetime[notification.desktop_id] = notification.timestamp;
sort_list_model.section_sorter.changed (DIFFERENT);
}

list_store.append (notification);
Expand Down
Loading