Skip to content

NotificationList: find notification when removing, not entry #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 4 commits into from
Sep 4, 2026
Merged

NotificationList: find notification when removing, not entry #338

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a12eb8e
NotificationList: find notification when removing, not entry
danirabbit Sep 3, 2026
477e1d6
Merge branch 'main' into danirabbit/notificationlist-removebug
danirabbit Sep 3, 2026
936e58e
fix review comment
danirabbit Sep 4, 2026
4f8fbd7
Merge branch 'main' into danirabbit/notificationlist-removebug
danirabbit Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Widgets/NotificationsList.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public class Notifications.NotificationsList : Granite.Bin {

var notification_entry = new NotificationEntry ();
notification_entry.bind (notification);
notification_entry.remove.connect (remove_notification);
notification_entry.remove.connect (() => remove_notification (notification));

return notification_entry;
}
Expand Down Expand Up @@ -167,13 +167,13 @@ public class Notifications.NotificationsList : Granite.Bin {
items_changed ();
}

private void remove_notification (NotificationEntry notification_entry) {
var app_id = notification_entry.notification.desktop_id;
private void remove_notification (Notification notification) {
var app_id = notification.desktop_id;

uint pos = -1;
if (list_store.find (notification_entry, out pos)) {
if (list_store.find (notification, out pos)) {
list_store.remove (pos);
Session.get_instance ().remove_notification (notification_entry.notification);
Session.get_instance ().remove_notification (notification);
}

var items_for_appid = new Gtk.FilterListModel (
Expand Down
Loading