Skip to content

Bubble: don't rely on system text styles #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 3 commits into from
Sep 10, 2026
Merged

Bubble: don't rely on system text styles #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d645560
Bubble: don't rely on system text styles
danirabbit Sep 8, 2026
e163727
CSS: add text styles
danirabbit Sep 8, 2026
3e292aa
Merge branch 'main' into danirabbit/bubble-urgentlabel
danirabbit Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions data/application.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ button.osd {
margin: 16px;
}

.notification .draw-area label.title {
font-weight: 700;
}

.notification .draw-area label.title image {
color: color-mix(in srgb, var(@fg_color) 78%, transparent);
}

.notification.reduce-transparency .draw-area {
margin: 16px;
background: @base_color;
Expand Down
9 changes: 6 additions & 3 deletions src/Bubble.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ public class Notifications.Bubble : AbstractBubble {

var contents = new Contents (value);

if (value.priority == URGENT) {
contents.add_css_class ("urgent");
} else {
if (value.priority != URGENT) {
timeout = 4000;
}

Expand Down Expand Up @@ -162,6 +160,11 @@ public class Notifications.Bubble : AbstractBubble {

attach (action_area, 0, 2, 2);
}

if (notification.priority == URGENT) {
add_css_class ("urgent");
title_label.add_css_class (Granite.CssClass.ERROR);

@wpkelso wpkelso Sep 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "urgent" always imply an error? Even if it's linked to the same styles, should this have a semantic Granite.CssClass.URGENT class added?

@danirabbit danirabbit Sep 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of goes with elementary/granite#1022

Basically, I think urgent should be defined as an emergency which to me is semantically similar to error

}
}
}
}
Loading