Introduce per process GPU usage #490

stsdc · 2025-10-31T22:29:51Z

Needs testing on hardware.

Intel (i915 driver)
Intel (Xe driver)
AMD Radeon
nVidia

…e settings

Tbusk · 2025-11-19T20:41:57Z

This doesn't currently work on my AMD gpu. The reason is that drm-engine-render doesn't have any values on my system.

drm-engine-gfx however does yield results that are comparable to other apps like Resources.

So adding a fall-through case above drm-engine-render is working on my system.

I updated the percentage shown to one digit like the other app shows for testing.

stsdc · 2025-11-20T13:02:20Z

May I ask you to propose a PR that works for you?

I'm wondering what would be the best solution to choose the right engine to read. We need to read driver name from GPU class and based on that do the right choice.

Tbusk · 2025-11-22T17:57:38Z

@stsdc I've been looking around, but the kernel docs are not the clearest on this.

Instead, its easier to simply read the output from various files in fdinfo on various setups.

Doing this, there only shows up two engines and that the driver is amdgpu, which afaik is the open-source driver version that is most used.

Here is info from a heavy gpu process:
sudo cat /proc/15768/fdinfo/6

pos:	0
flags:	02100002
mnt_id:	29
ino:	1197
drm-driver:	amdgpu
drm-client-id:	126
drm-pdev:	0000:03:00.0
pasid:	32793
drm-total-cpu:	0
drm-shared-cpu:	0
drm-resident-cpu:	0
drm-purgeable-cpu:	0
drm-total-gtt:	14716 KiB
drm-shared-gtt:	0
drm-resident-gtt:	14716 KiB
drm-purgeable-gtt:	0
drm-total-vram:	90340 KiB
drm-shared-vram:	2320 KiB
drm-resident-vram:	90340 KiB
drm-purgeable-vram:	25344 KiB
drm-total-gds:	0
drm-shared-gds:	0
drm-resident-gds:	0
drm-purgeable-gds:	0
drm-total-gws:	0
drm-shared-gws:	0
drm-resident-gws:	0
drm-purgeable-gws:	0
drm-total-oa:	0
drm-shared-oa:	0
drm-resident-oa:	0
drm-purgeable-oa:	0
drm-total-doorbell:	0
drm-shared-doorbell:	0
drm-resident-doorbell:	0
drm-purgeable-doorbell:	0
drm-memory-vram:	90340 KiB
drm-memory-gtt: 	14716 KiB
drm-memory-cpu: 	0 KiB
amd-evicted-vram:	0 KiB
amd-requested-vram:	90340 KiB
amd-requested-gtt:	14716 KiB
drm-engine-gfx:	420209306 ns
drm-engine-compute:	1370523 ns

The drm-engine-gfx is the only one that is incrementing over time.

https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/amd/include/amd_shared.h

I'm assuming that engine is called the Graphics and Compute Engine.

There also appears to be a pro version of the driver, but I don't have that right now. I think I can get it by installing ROCm, but I'm not sure I'd need it for a while, and it is a bit of a hassle. Might be easier to rent a server briefly to get this gpu information.

stsdc · 2025-11-22T19:13:03Z

@Tbusk also check what Resources does: https://github.com/nokyan/resources/blob/main/lib/process_data/src/gpu_usage.rs
Nokyan figured this out some time ago.
I just need your PR to make sure that it works for AMD. You can edit Intel specific part drm-engine-render → drm-engine-gfx and whatever needed. It will make this code AMD specific. But when I'll introduce some sort of manager (or factory?) to create a Process object with the right method, we will have support for both Intel and AMD.

Tbusk · 2025-11-22T19:30:41Z

Just checked what my nvidia 3000 series laptop is running during a stress test (which works on the PR) towards both my onboard graphics and my nvidia card:

I have nvidia-driver-570 installed.

cat /proc/5115/fdinfo/17

pos:	0
flags:	02100002
mnt_id:	29
ino:	970
drm-driver:	i915
drm-client-id:	100
drm-pdev:	0000:00:02.0
drm-total-system0:	124508 KiB
drm-shared-system0:	20 MiB
drm-active-system0:	104632 KiB
drm-resident-system0:	124508 KiB
drm-purgeable-system0:	412 KiB
drm-total-stolen-system0:	0
drm-shared-stolen-system0:	0
drm-active-stolen-system0:	0
drm-resident-stolen-system0:	0
drm-purgeable-stolen-system0:	0
drm-engine-render:	70853540131 ns
drm-engine-copy:	0 ns
drm-engine-video:	0 ns
drm-engine-capacity-video:	2
drm-engine-video-enhance:	0 ns

Also the only addition needed to make it work on my amd machine is to add a fall-though case above your case in the switch in src/Managers/Process.vala @stsdc which is why it is working in my screenshots.

So

case "drm-engine-gfx":
case "drm-engine-render":

I can do a pr if you want.

stsdc · 2025-11-22T19:56:44Z

I'll appreciate if you'll make a PR.
Also wondering if we should sum up drm-engine-gfx and drm-engine-compute, or any other engines? 🤔

Tbusk · 2025-11-22T21:04:16Z

I'll appreciate if you'll make a PR. Also wondering if we should sum up drm-engine-gfx and drm-engine-compute, or any other engines? 🤔

After looking at it a little, the value of drm-engine-compute does go up, but in increments much smaller than the other.

Example of a handful of minutes difference in a stress test:

drm-engine-gfx:	44629292665 ns
drm-engine-compute:	3848787 ns

drm-engine-gfx:	186754994879 ns
drm-engine-compute:	4071513 ns

stsdc · 2025-11-26T14:21:57Z

@Tbusk please check if it works for you now

Tbusk · 2025-11-26T19:02:46Z

@Tbusk please check if it works for you now

@stsdc it is working for amd setup.

ryonakano

@stsdc Sorry for late review. Just glimpsed and leaving some comments about coding styles and scopes; I haven't tested yet.

ryonakano · 2025-12-27T02:32:20Z

src/Managers/Process.vala

    public string username = Utils.NO_DATA;

+    // Update interval in seconds is used to calculate GPU usage
+    public int update_interval;


Is this need to be public? I think we should lessen scope as possible for new codes.

ryonakano · 2025-12-27T02:33:02Z

src/Managers/Process.vala

    public ProcessIO io;

+    // Contains info about GPU usage
+    public ProcessDRM drm;


Same comment goes here.

ryonakano · 2025-12-27T02:34:53Z

src/Managers/Process.vala

-    private uint64 last_total;
+    public double gpu_percentage { get; private set; }
+
+    private uint64 last_total; // Obsolete?


What does this comment mean? Is it TODO?

ryonakano · 2025-12-27T02:36:19Z

src/Managers/Process.vala

-    /**
-     * Reads the /proc/%pid%/cmdline file and updates from the information contained therein.
-     */
+/**
+ * Reads the /proc/%pid%/cmdline file and updates from the information contained therein.
+ */


Documentation comments for a method should have the same indentation with the method as the previous code does.

ryonakano · 2025-12-27T02:37:50Z

src/Managers/ProcessDRM.vala

+            if (err is FileError.ACCES) {
+
+            } else {
+                warning (err.message);
+            }


Is there any reason you crush FileError.ACCES error? Same reason with the following commnet?

// if the error is not no access to file, because regular user

If so please explicit by adding a comment here too.

Also, isn't it possible to write something like this? I commented without testing if this is grammatically correct though.

if (!(err is FileError.ACCES)) { warning (err.message); }

ryonakano · 2025-12-27T02:38:48Z

src/Managers/ProcessDRM.vala

+                        update_engine (splitted_line[1], ref last_engine_render);
+                        break;
+                    default:
+                        // warning ("Unknown value in %s", path);


Why this is commented out?

ryonakano · 2025-12-27T02:42:26Z

src/Managers/ProcessDRM.vala

+                    }
+                }
+            } catch (Error e) {
+                if (e.code != 14) {


What 14 mean here?

ryonakano · 2025-12-27T02:45:50Z

src/Views/ProcessView/ProcessTreeView/CPUProcessTreeView.vala

+        if (gpu_usage < 0.0)
+            ((Gtk.CellRendererText)cell).text = Utils.NO_DATA;
+        else
+            ((Gtk.CellRendererText)cell).text = "%.0f%%".printf (gpu_usage);


Suggested change

if (gpu_usage < 0.0)

((Gtk.CellRendererText)cell).text = Utils.NO_DATA;

else

((Gtk.CellRendererText)cell).text = "%.0f%%".printf (gpu_usage);

if (gpu_usage < 0.0) {

((Gtk.CellRendererText)cell).text = Utils.NO_DATA;

} else {

((Gtk.CellRendererText)cell).text = "%.0f%%".printf (gpu_usage);

}

Please always explicit brackets to prevent bugs in case we added additional lines here in the future.

See also https://docs.elementary.io/develop/writing-apps/code-style#vala:

On conditionals and loops, always use braces even if there's only one line of code:

if (my_var > 2) { print ("hello\n"); }

Introduce per process GPU usage

cac2491

stsdc marked this pull request as draft October 31, 2025 22:31

stsdc added 3 commits November 2, 2025 17:12

Add some comments

d5f9686

Fix lint

7a38179

Merge branch 'main' into stsdc/process-gpu-usage

13b61ff

stsdc marked this pull request as ready for review November 2, 2025 16:59

stsdc requested a review from a team November 2, 2025 16:59

stsdc marked this pull request as draft November 2, 2025 17:04

stsdc added 3 commits November 6, 2025 16:32

Get update_interval for the per process GPU usage calculation from th…

5243cfc

…e settings

Merge branch 'main' into stsdc/process-gpu-usage

2ba0e9b

Refactor get_usage_gpu()

2d82102

stsdc marked this pull request as ready for review November 16, 2025 00:10

stsdc added 3 commits November 16, 2025 01:11

Merge branch 'main' into stsdc/process-gpu-usage

6cf1db2

Merge branch 'main' into stsdc/process-gpu-usage

555949f

Merge branch 'main' into stsdc/process-gpu-usage

70e7325

stsdc added 3 commits November 25, 2025 19:45

Merge branch 'main' into stsdc/process-gpu-usage

d9677e7

Refactor GPU usage handling by introducing ProcessDRM class

35202a7

Refactor ProcessDRM

54b9a86

Remove leftovers

8bd4800

Merge branch 'main' into stsdc/process-gpu-usage

61666d8

ryonakano reviewed Dec 27, 2025

View reviewed changes

Uh oh!

Introduce per process GPU usage #490

Are you sure you want to change the base?

Introduce per process GPU usage #490

Conversation

stsdc commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tbusk commented Nov 19, 2025

Uh oh!

stsdc commented Nov 20, 2025

Uh oh!

Tbusk commented Nov 22, 2025

Uh oh!

stsdc commented Nov 22, 2025

Uh oh!

Tbusk commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stsdc commented Nov 22, 2025

Uh oh!

Tbusk commented Nov 22, 2025

Uh oh!

stsdc commented Nov 26, 2025

Uh oh!

Tbusk commented Nov 26, 2025

Uh oh!

ryonakano left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stsdc commented Oct 31, 2025 •

edited

Loading

Tbusk commented Nov 22, 2025 •

edited

Loading