Skip to content

SourceList: GTK4 prep - #1084

Merged
jeremypw merged 9 commits into
masterfrom
danirabbit/sourcelist-styleprop
Aug 9, 2026
Merged

SourceList: GTK4 prep#1084
jeremypw merged 9 commits into
masterfrom
danirabbit/sourcelist-styleprop

Conversation

@danirabbit

@danirabbit danirabbit commented Aug 7, 2026

Copy link
Copy Markdown
Member
  • install_style_property and style_get are gone in GTK4
  • Replace constants removed in GTK4
  • remove unnecessary Granite.STYLE_CLASS_SOURCE_LIST
  • remove unnecessary stock_size
  • remove public override bool popup_menu () which is gone in GTK4
  • align is FILL by default, only needs vexpand
  • remove dead CSS
  • clean up code style
Screenshot from 2026-08-07 09 56 07

@danirabbit
danirabbit requested a review from a team August 7, 2026 16:58
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Aug 7, 2026
@danirabbit danirabbit changed the title SourceList: replace install_style, style_get SourceList: GTK4 prep Aug 7, 2026
@jeremypw

jeremypw commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Looks like you are going to port SourceList as is to Gtk4. In that case, I'll copy your work intoCode when you have finished if that's OK.

@danirabbit

Copy link
Copy Markdown
Member Author

@jeremypw going to attempt to at least! And yes absolutely if it works out please :)

@jeremypw

jeremypw commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Probably the only place SourceList is fully used now is in Code's projects sidebar. Photos has something similar but its own code. It seems under-used in Mail tbh.

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appearance looks pretty much the same and code sane.

@jeremypw
jeremypw merged commit 26511fe into master Aug 9, 2026
6 checks passed
@jeremypw
jeremypw deleted the danirabbit/sourcelist-styleprop branch August 9, 2026 11:55
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in GTK4 Porting Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants