SourceList: GTK4 prep - #1084
Merged
Merged
Conversation
Contributor
|
Looks like you are going to port SourceList as is to Gtk4. In that case, I'll copy your work intoCode when you have finished if that's OK. |
Member
Author
|
@jeremypw going to attempt to at least! And yes absolutely if it works out please :) |
Contributor
|
Probably the only place SourceList is fully used now is in Code's projects sidebar. Photos has something similar but its own code. It seems under-used in Mail tbh. |
jeremypw
approved these changes
Aug 9, 2026
jeremypw
left a comment
Contributor
There was a problem hiding this comment.
Appearance looks pretty much the same and code sane.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install_style_propertyandstyle_getare gone in GTK4Granite.STYLE_CLASS_SOURCE_LISTstock_sizepublic override bool popup_menu ()which is gone in GTK4alignisFILLby default, only needsvexpand