Skip to content

Construct image label button for GTK4 #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 3 commits into from
Aug 5, 2026
Merged

Construct image label button for GTK4 #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e845ea
Composer: construct image label button for GTK4
danirabbit Aug 5, 2026
d7331df
SignatureDialog: construct image label button for GTK4
danirabbit Aug 5, 2026
48312f8
Merge branch 'master' into danirabbit/button-with-image
danirabbit Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Composer.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,14 @@ public class Mail.Composer : Hdy.ApplicationWindow {
tooltip_text = _("Insert Signature…")
};

var send = new Gtk.Button.from_icon_name ("mail-send-symbolic", Gtk.IconSize.MENU) {
var send_buttonbox = new Gtk.Box (HORIZONTAL, 0);
send_buttonbox.add (new Gtk.Image.from_icon_name ("mail-send-symbolic", MENU));
send_buttonbox.add (new Gtk.Label (_("Send")));

var send = new Gtk.Button () {
action_name = ACTION_PREFIX + ACTION_SEND,
always_show_image = true,
label = _("Send"),
child = send_buttonbox,
margin_top = 6,
margin_end = 0,
margin_bottom = 6,
margin_start = 6,
sensitive = false,
Expand Down
9 changes: 5 additions & 4 deletions src/Dialogs/SignatureDialog/SignatureDialog.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,14 @@ public class Mail.SignatureDialog : Hdy.ApplicationWindow {

var default_menu = new Menu ();

var default_buttonbox = new Gtk.Box (HORIZONTAL, 0);
default_buttonbox.add (new Gtk.Label (_("Set Default For…")));
default_buttonbox.add (new Gtk.Image.from_icon_name ("pan-down-symbolic", SMALL_TOOLBAR));

var default_menubutton = new Gtk.MenuButton () {
always_show_image = true,
child = default_buttonbox,
halign = END,
image = new Gtk.Image.from_icon_name ("pan-down-symbolic", SMALL_TOOLBAR),
image_position = RIGHT,
menu_model = default_menu,
label = _("Set Default For…"),
use_popover = false,
direction = UP,
sensitive = false
Expand Down