SourceList: use button and key controllers - #1067
Merged
Merged
Conversation
ryonakano
reviewed
Aug 3, 2026
Member
|
@danirabbit Hi, could you tell me how I can test this? |
Member
I asked you because I'm not familiar with this code base and I couldn't confirm the F2 key works which I saw in the diff of this PR, so I wanted to know how you test this. But I can confirm the above issue even in latest master branch so I opened #1071 as it's not related to this PR. I can't test anything with this PR, but changes looks good to me so I'm approving this. |
ryonakano
approved these changes
Aug 4, 2026
Member
Author
|
Yeah I can confirm I can't get renaming to work in master either |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.