Skip to content

FolderList: use GLib.Menu for main menu - #1060

Merged
danirabbit merged 4 commits into
masterfrom
danirabbit/folderlist-menumodel
Aug 4, 2026
Merged

FolderList: use GLib.Menu for main menu#1060
danirabbit merged 4 commits into
masterfrom
danirabbit/folderlist-menumodel

Conversation

@danirabbit

Copy link
Copy Markdown
Member

ModelButton is sealed in GTK4. Just use a menu model here

@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Jul 27, 2026
@danirabbit
danirabbit requested a review from a team July 27, 2026 23:14

@ryonakano ryonakano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the menu (now changed from a popover) shown as before and each menuitem works as expected.

@danirabbit
danirabbit enabled auto-merge (squash) August 3, 2026 22:34
@danirabbit
danirabbit merged commit 94d6417 into master Aug 4, 2026
5 of 6 checks passed
@danirabbit
danirabbit deleted the danirabbit/folderlist-menumodel branch August 4, 2026 22:01
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in GTK4 Porting Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants