Skip to content

DiskBar: Add some safety checks to constraints calculations #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 3 commits into from
Aug 17, 2025
+8 −2
Merged

DiskBar: Add some safety checks to constraints calculations #901

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2da36fd
DiskBar: Add some safety checks to constraints calculations
lenemter Aug 16, 2025
916df12
1% as minimum partition size
lenemter Aug 16, 2025
9734924
Merge branch 'main' into lenemter/try-to-fix-crashes
danirabbit Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Widgets/DiskBar.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ public class Installer.DiskBar: Gtk.Box {
);
}

// make sure if somehow used_sectors > total_disk_sectors, we clamp it to total_disk_sectors
used_sectors = uint64.min (used_sectors, total_disk_sectors);

// If more than 1% of the disk is unused, show a block for the unused space
var unused_sectors = total_disk_sectors - used_sectors;
if ((double) unused_sectors / total_disk_sectors > 0.01) {
Expand Down Expand Up @@ -147,8 +150,11 @@ public class Installer.DiskBar: Gtk.Box {
}

private void append_partition (Gtk.Widget widget, double percentage) {
// Truncate to 2 decimal places (round down), to ensure we don't go over 100% because of rounding errors
percentage = (int)(percentage * 100) / 100.0;
// Truncate to 2 decimal places (round down), to ensure we don't go over 100% because of rounding errors.
// Also make sure percentage is never 0, otherwise we can assertion error:
// gtk_constraint_expression_new_subject: assertion failed: (!G_APPROX_VALUE (term->coefficient, 0.0, 0.001))
// Also we assume partitions.size is less than 100
percentage = ((int) (percentage * 100) / 100.0).clamp (0.01, 1.0 - partitions.size / 100.0);

widget.set_parent (this);

Expand Down