Skip to content

Utils: Don't check for logical framebuffer on mutter-50+ - #2923

Merged
leolost2605 merged 1 commit into
elementary:mainfrom
garaevdi:remove-logical-framebuffer-check
Sep 8, 2026
Merged

Utils: Don't check for logical framebuffer on mutter-50+#2923
leolost2605 merged 1 commit into
elementary:mainfrom
garaevdi:remove-logical-framebuffer-check

Conversation

@garaevdi

@garaevdi garaevdi commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

It was enable by default since https://gitlab.gnome.org/GNOME/mutter/-/commit/74965cdb047df0f2159d53cb12770949924c60e9 which makes this check redundant.

Also in mutter-51 gnome devs changed the underlying gschema which caused crashes on gala side.

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One note though: this is in theory not correct since you can still set the monitor layout mode to physical via the monitor config dbus interface. However since there is no UI to do that (the easiest way is probably gdctl) and not really a reason afaik I think it's fine to say we just don't support it

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

Comment thread lib/Utils.vala
@garaevdi
garaevdi force-pushed the remove-logical-framebuffer-check branch from c235e6e to d39d25f Compare September 5, 2026 08:42
It was enable by default since
https://gitlab.gnome.org/GNOME/mutter/-/commit/74965cdb047df0f2159d53cb12770949924c60e9
which makes this check redundant.

Also in mutter-51 gnome devs changed the underlying gschema which caused
crashes on gala side.
@leolost2605
leolost2605 force-pushed the remove-logical-framebuffer-check branch from d39d25f to 5445cca Compare September 8, 2026 09:03
@leolost2605
leolost2605 enabled auto-merge (squash) September 8, 2026 09:04
@leolost2605
leolost2605 merged commit f0ebed2 into elementary:main Sep 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants