Skip to content

WindowMenu: Use unique bus name - #2898

Merged
lenemter merged 2 commits into
mainfrom
leolost/window-menu-new-bus-name
Aug 13, 2026
Merged

lenemter merged 2 commits into
mainfrom
leolost/window-menu-new-bus-name

Conversation

@leolost2605

Copy link
Copy Markdown
Member

We currently do Bus.own_name with the same name in two places causing one to loose the name (DBus.vala prints a warning on every start). Everything is still working and all exported objects are still there and functioning but I think it's better to not rely on that.
So now we have two options:

  • have DBus.vala export the menu and action group
  • use another bus name

I went with the second option because it keeps everything neatly contained in the WindowMenuManager and also regarding naming conventions this is how e.g. mutter (and most others?) do it (mutter uses a matching bus name for every object it exports).
I don't have much of an opinion here so we can also go with the first option 🤷

While here fix an oversight in the gtk3 daemon where old object paths were used.

@leolost2605
leolost2605 requested a review from a team August 13, 2026 11:37

@lenemter lenemter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@lenemter
lenemter merged commit 07067b0 into main Aug 13, 2026
7 checks passed
@lenemter
lenemter deleted the leolost/window-menu-new-bus-name branch August 13, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants