WindowMenu: Use unique bus name - #2898
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently do Bus.own_name with the same name in two places causing one to loose the name (DBus.vala prints a warning on every start). Everything is still working and all exported objects are still there and functioning but I think it's better to not rely on that.
So now we have two options:
I went with the second option because it keeps everything neatly contained in the WindowMenuManager and also regarding naming conventions this is how e.g. mutter (and most others?) do it (mutter uses a matching bus name for every object it exports).
I don't have much of an opinion here so we can also go with the first option 🤷
While here fix an oversight in the gtk3 daemon where old object paths were used.