Skip to content

Port to GTK4 - #645

Merged
danirabbit merged 61 commits into
masterfrom
danirabbit/gtk4
Aug 13, 2026
Merged

Port to GTK4#645
danirabbit merged 61 commits into
masterfrom
danirabbit/gtk4

Conversation

@danirabbit

@danirabbit danirabbit commented May 28, 2025

Copy link
Copy Markdown
Member

Fixes #88
Fixes #488
Fixes #560

@danirabbit danirabbit moved this to In Progress in GTK4 Porting May 28, 2025
Comment thread src/Backend/App.vala

var context = Gdk.Display.get_default ().get_app_launch_context ();
context.set_timestamp (Gtk.get_current_event_time ());
context.set_timestamp (Gdk.CURRENT_TIME);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from Marukesu:

In gtk4, we have Gtk.EventController.get_current_event_time(), so it's better to leave this as it is now or refactor the code to pass the time from the event handlers to the methods.

@danirabbit danirabbit added this to OS 9 Jan 13, 2026
@danirabbit danirabbit moved this to In progress in OS 9 Jan 13, 2026
@danirabbit danirabbit moved this from In Progress to Needs Review in GTK4 Porting Aug 11, 2026
@danirabbit
danirabbit marked this pull request as ready for review August 11, 2026 16:42
@danirabbit
danirabbit requested a review from a team August 11, 2026 16:43
@danirabbit

Copy link
Copy Markdown
Member Author

@ryonakano do we wanna get this merged today? :)

@danirabbit danirabbit mentioned this pull request Aug 13, 2026
@danirabbit
danirabbit merged commit 0bf3bf5 into master Aug 13, 2026
2 of 4 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in GTK4 Porting Aug 13, 2026
@github-project-automation github-project-automation Bot moved this from In progress to Done in OS 9 Aug 13, 2026
@danirabbit
danirabbit deleted the danirabbit/gtk4 branch August 13, 2026 21:58
@ryonakano

Copy link
Copy Markdown
Member

@danirabbit Sorry for late response, I was in bed 😴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

Port to GTK4 Incorrect placement of tooltip Search field placeholder is only visible while the app menu is fading out

3 participants