ListModels: Use n items instead of custom properties#2427
Merged
danirabbit merged 2 commits intomainfrom Mar 1, 2026
Merged
Conversation
All models in GTK and GLib have an n-items property. So bind to that instead of having to manage custom properties. Also drop up_to_date since that is not used anywhere anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All models in GTK and GLib have a n-items property. So bind to that instead of having to manage custom properties which allows for a bit of cleanup.
Also drop up_to_date since that is not used anywhere anymore.
We also don't need the has_... properties since we can just bind an int to a bool and 0 will be converted to false and anything else to true which saves us any mapping funcs.