This repository was archived by the owner on Jul 19, 2021. It is now read-only.
Numeric nil type cast fix #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only should have to patch Column#type_cast_for_write and AR#_field_changed?, while leaving Column#type_cast untouched.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to re-do the whole approach, there is no need to override both
AR::CA::Column#type_cast_for_writeandAR::CA::Column#type_cast, instead onlyAR::CA::Column#type_cast_for_writewithAR::Base#_field_changed?need to be patched.@maintux can you also test it? I think the new code won't have any of the problems you were trying to fix in #2, #3 or #4.