Repository navigation
Conversation
|
@Revan0809 is attempting to deploy a commit to the electrohyun's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: electrohyun/smocket/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for the contribution! But, I'd like to keep the remaining good first issues available for other new contributors, so I'll close this PR. |
Summary
The command tables in
CONTRIBUTING.mdandCONTRIBUTING.ko.mdsaidpnpm typecheck"produces no output," but it also builds packages (tsup && tsc --noEmit && ... && pnpm --filter smocket-client build && ...). They also describedpnpm lintas checking "documentation style," but the ESLint config (eslint.config.*) only targets**/*.{ts,mts,cts}.pnpm typecheck→ "Build packages and check types" (English) / "패키지 빌드 및 타입 검사" (Korean)pnpm lint→ "Lint TypeScript source files" (English) / "TypeScript 소스 파일 린트" (Korean)The commands themselves are unchanged.
Fixes #523
Test plan
pnpm typecheck's actual definition inpackage.jsonbuilds packages (not just type-checks)eslint.config.*only targets.ts/.mts/.ctsfilespnpm format— reformattedCONTRIBUTING.ko.md's table column widths to match the new text (confirmed via diff that only the two edited rows' wording changed)🤖 Generated with Claude Code