docs: add Chromium installation to example verification instructions - #543
Conversation
|
@Revan0809 is attempting to deploy a commit to the electrohyun's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: electrohyun/smocket/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
electrohyun
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Summary
Both
examples/drawing-gameandexamples/shared-worker-lobbyoffer browser verification (pnpm example:drawing-game:verify/pnpm example:shared-worker), but neither README mentioned that Playwright needs Chromium installed first. CI already installs it (.github/workflows/ci.ymlrunspnpm exec playwright install --with-deps chromium) before running these checks, so a first-time local run of the verify commands fails without this.pnpm exec playwright install chromiumfrom the repository root."pnpm example:drawing-game:test) don't need Chromium, so they're left alone.Fixes #522
Test plan
pnpm format— 0 changes to the two edited files (formatting already correct)🤖 Generated with Claude Code