Skip to content

fix: correct the drawing-game Socket.IO version labels to 4.8.4 - #542

Merged
electrohyun merged 2 commits into
electrohyun:mainfrom
Revan0809:fix/drawing-game-socketio-version-labels
Oct 1, 2026
Merged

electrohyun merged 2 commits into
electrohyun:mainfrom
Revan0809:fix/drawing-game-socketio-version-labels

Conversation

@Revan0809

Copy link
Copy Markdown
Contributor

Summary

The drawing-game example's dependencies are pinned to socket.io/socket.io-client 4.8.4, but the observation output and README still said 4.8.3.

  • examples/drawing-game/observe.ts: the targets key is now socket.io@4.8.4.
  • examples/drawing-game/README.md: both version mentions in the "Run with Real Socket.IO" section updated to 4.8.4.

Fixes #521

Test plan

  • Built the workspace (pnpm build at the root, pnpm --filter smocket-client build) and ran pnpm observe in examples/drawing-game — output now reports "socket.io@4.8.4" and "deeplyEqual": true
  • Confirmed no remaining 4.8.3 references anywhere under examples/drawing-game/

🤖 Generated with Claude Code

@Revan0809
Revan0809 requested a review from electrohyun as a code owner October 1, 2026 12:46
@vercel

vercel Bot commented Oct 1, 2026

Copy link
Copy Markdown

@Revan0809 is attempting to deploy a commit to the electrohyun's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: electrohyun/smocket/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3c28a090-82fb-4136-952c-80606d6d04d1

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added bug Something isn't working 📏 xs Pull request changes fewer than 10 lines good first issue Good for newcomers labels Oct 1, 2026
@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
smocket Skipped Skipped Oct 1, 2026 12:55pm UTC

@electrohyun electrohyun left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@electrohyun
electrohyun merged commit 87ec3bc into electrohyun:main Oct 1, 2026
17 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 90301953 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working good first issue Good for newcomers 📏 xs Pull request changes fewer than 10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: correct the drawing-game Socket.IO version labels

2 participants