Fix Eva release branch asset publishing#179
Conversation
|
Warning Review limit reached
More reviews will be available in 54 minutes and 46 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow's ChangesRelease Workflow Gating and Tag Resolution
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 104-118: In the "Resolve Eva release tag" step, the template
expression ${{ inputs.tag_name }} is being directly interpolated into the bash
script, creating a template injection vulnerability. Fix this by defining
inputs.tag_name as an environment variable in the step's env section, then
reference that environment variable (such as $TAG_NAME) within the bash script
instead of using the direct template interpolation for the release_tag
assignment.
- Around line 61-75: The "Resolve Eva release tag" step has a template injection
vulnerability where ${{ inputs.tag_name }} is directly interpolated into the
shell script. To fix this, add an env section to the step that passes the input
as an environment variable (e.g., env: INPUT_TAG: ${{ inputs.tag_name }}), then
reference the environment variable in the shell script
(release_tag="$INPUT_TAG") instead of using the direct template interpolation.
This prevents arbitrary shell command injection through a malicious tag name
input.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9cf1a649-2263-49b9-8643-c91f1275c0ad
📒 Files selected for processing (1)
.github/workflows/release.yml
Closes #178.
TL;DR
Release branches should produce complete Eva release artifacts, not just create a source tag. This PR fixes the release workflow so
release/eva-v*branch pushes create or reuse the matching tag, then build and uploadgbrain-darwin-arm64,gbrain-linux-x64, andSHA256SUMSin the same workflow run.Why
The
.8rollout candidate exposed a release-channel gap:release/eva-v0.42.47.8created the tag, but GitHub did not run the tag-triggered build afterward because tag pushes made byGITHUB_TOKENdo not recursively trigger workflows. The result was a visible source-only release, which is not good enough for a fleet rollout gate.What Changed
buildandreleasejobs to run onrelease/eva-v*branch events.workflow_dispatchworking.RELEASE_TAGsafely for branch, tag, and manual-dispatch events.Validation
git diff --checkpassed.release/eva-v0.42.47.8.Fleet Impact
No runtime code changes. This is release plumbing only; fleet rollout remains pinned to
eva-v0.42.47.8after the release assets are published.Summary by CodeRabbit
Note: This release contains only internal infrastructure updates with no user-facing changes.