Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(qa): gate-severity audit — stop FATAL behavioral gates false-capping short emergent duos #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(qa): gate-severity audit — stop FATAL behavioral gates false-capping short emergent duos #1030
Changes from all commits
af86a814ea6aaa22d21f2698636cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scope abandon detection to the latest combat segment.
At Line 386,
_abandonedcheckstools.get("end_combat", 0) == 0globally. If one combat ended earlier but a later combat was left active, this incorrectly downgrades a genuine abandon to WARN.💡 Suggested fix
_last_sc = max((i for i, c in enumerate(_ordered_short) if c == "start_combat"), default=-1) + _last_ec = max((i for i, c in enumerate(_ordered_short) if c == "end_combat"), + default=-1) @@ - _abandoned = ( + current_fight_unclosed = (_last_sc >= 0 and _last_ec < _last_sc) + _abandoned = ( len(mv) >= COMBAT_ABANDON_MIN_BEATS and not started_late - and tools.get("end_combat", 0) == 0 + and current_fight_unclosed )🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.