Skip to content

Theseus aligner #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
electricEpilith wants to merge 84 commits into
base: master
Choose a base branch
from

commit theseus-lib changes

bbd96ea
Select commit
Loading
Failed to load commit list.
Open

Theseus aligner #6

commit theseus-lib changes
bbd96ea
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 8, 2026 in 19m 45s

Quality Gate passed

Issues
109 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 53 in src/unittest/support/snarl_decomposition_fuzzer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8suTOqzDl7DU547&open=AZ1uR8suTOqzDl7DU547&pullRequest=6

Check failure on line 23 in src/unittest/snarl_decomposition_fuzzer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8ydTOqzDl7DU55G&open=AZ1uR8ydTOqzDl7DU55G&pullRequest=6

Check warning on line 147 in src/unittest/support/snarl_decomposition_fuzzer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "vg::unittest::DecompositionEventType". 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8suTOqzDl7DU54y&open=AZ1uR8suTOqzDl7DU54y&pullRequest=6

Check failure on line 1593 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55k&open=AZ1uR8zPTOqzDl7DU55k&pullRequest=6

Check warning on line 447 in src/gbwtgraph_helper.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 26 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR84eTOqzDl7DU56C&open=AZ1uR84eTOqzDl7DU56C&pullRequest=6

Check warning on line 1027 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 23 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55X&open=AZ1uR8zPTOqzDl7DU55X&pullRequest=6

Check failure on line 1623 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55n&open=AZ1uR8zPTOqzDl7DU55n&pullRequest=6

Check warning on line 19 in src/unittest/support/snarl_decomposition_fuzzer.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Concatenate this namespace with the nested one. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8shTOqzDl7DU54n&open=AZ1uR8shTOqzDl7DU54n&pullRequest=6

Check warning on line 3156 in src/minimizer_mapper_from_chains.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "." with "::" for access to "HandleGraphTheseusAdapter::handle_name". 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR82-TOqzDl7DU559&open=AZ1uR82-TOqzDl7DU559&pullRequest=6

Check warning on line 19 in src/unittest/support/snarl_decomposition_fuzzer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused lambda capture "graph". 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8suTOqzDl7DU540&open=AZ1uR8suTOqzDl7DU540&pullRequest=6

Check warning on line 8148 in src/unittest/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8wATOqzDl7DU55C&open=AZ1uR8wATOqzDl7DU55C&pullRequest=6

Check warning on line 1276 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused parameter "next_handle", make it unnamed, or declare it "[[maybe_unused]]". 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55f&open=AZ1uR8zPTOqzDl7DU55f&pullRequest=6

Check warning on line 1406 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested conditional operator into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55q&open=AZ1uR8zPTOqzDl7DU55q&pullRequest=6

Check warning on line 1693 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused parameter "snarl_index", make it unnamed, or declare it "[[maybe_unused]]". 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55y&open=AZ1uR8zPTOqzDl7DU55y&pullRequest=6

Check warning on line 445 in src/gbwtgraph_helper.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

unused variable 'total_zipcode_time' 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR84eTOqzDl7DU55_&open=AZ1uR84eTOqzDl7DU55_&pullRequest=6

Check failure on line 50 in src/unittest/support/snarl_decomposition_fuzzer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8suTOqzDl7DU544&open=AZ1uR8suTOqzDl7DU544&pullRequest=6

Check warning on line 1021 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested conditional operator into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55V&open=AZ1uR8zPTOqzDl7DU55V&pullRequest=6

Check failure on line 56 in src/theseus_interop.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR85ZTOqzDl7DU56F&open=AZ1uR85ZTOqzDl7DU56F&pullRequest=6

Check failure on line 177 in src/theseus_interop.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR85ZTOqzDl7DU56K&open=AZ1uR85ZTOqzDl7DU56K&pullRequest=6

Check warning on line 149 in src/unittest/support/snarl_decomposition_fuzzer.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not assign data members in a constructor. Initialize member "should_flip" in an initialization list. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8shTOqzDl7DU54p&open=AZ1uR8shTOqzDl7DU54p&pullRequest=6

Check failure on line 1518 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55j&open=AZ1uR8zPTOqzDl7DU55j&pullRequest=6

Check warning on line 206 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a reference-to-const. The current type of "node_record" is "struct bdsg::SnarlDistanceIndex::TemporaryDistanceIndex::TemporaryNodeRecord &". 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55J&open=AZ1uR8zPTOqzDl7DU55J&pullRequest=6

Check failure on line 1027 in src/snarl_distance_index.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8zPTOqzDl7DU55W&open=AZ1uR8zPTOqzDl7DU55W&pullRequest=6

Check warning on line 6 in src/unittest/support/snarl_decomposition_fuzzer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Concatenate this namespace with the nested one. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8suTOqzDl7DU54z&open=AZ1uR8suTOqzDl7DU54z&pullRequest=6

Check warning on line 20 in src/unittest/support/snarl_decomposition_fuzzer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "contains" member function. 

See more on https://sonarcloud.io/project/issues?id=electricEpilith_vg&issues=AZ1uR8suTOqzDl7DU541&open=AZ1uR8suTOqzDl7DU541&pullRequest=6
View more details on SonarQubeCloud