Document ELECTRIC_SHAPE_SUSPEND_AFTER in the config reference - #4793
Merged
Conversation
Since #4284 consumers always hibernate after ELECTRIC_SHAPE_HIBERNATE_AFTER and, when suspension is enabled, terminate a further ELECTRIC_SHAPE_SUSPEND_AFTER later. The docs still described ELECTRIC_SHAPE_HIBERNATE_AFTER as the suspend timeout and had no entry for the new variable. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GDTua3WEeQeDbcDjVTP395
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75ad310501
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Shapes with subquery dependencies and shapes other shapes depend on only ever hibernate, even with ELECTRIC_SHAPE_SUSPEND_CONSUMER enabled. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GDTua3WEeQeDbcDjVTP395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config reference was out of date since #4284 split hibernation from suspension:
ELECTRIC_SHAPE_HIBERNATE_AFTERnow only controls when an idle consumer hibernates.ELECTRIC_SHAPE_SUSPEND_AFTER(default10m) is the additional idle time after hibernation before a consumer is terminated whenELECTRIC_SHAPE_SUSPEND_CONSUMER=true. It had no docs entry.This rewrites the
ELECTRIC_SHAPE_SUSPEND_CONSUMERandELECTRIC_SHAPE_HIBERNATE_AFTERentries to describe the two-stage behaviour and adds an entry forELECTRIC_SHAPE_SUSPEND_AFTER.🤖 Generated with Claude Code
https://claude.ai/code/session_01GDTua3WEeQeDbcDjVTP395