Conversation
…nd LazyLock where appropriate. Rust does not support build-time definitions in the same way used in vbpf/prevail#1060, so we instead make those constants into global statics, which may be initialized once before any other library functions are called (otherwise they'll use the existing defaults). All references to those constants have been updated to use the statics, which unfortunately means that the implementation of crab/bitset_domain.rs is no longer constant size, and now uses `Vec`s. Signed-off-by: Venus Xeon-Blonde <venus@cloudflare.com>
Signed-off-by: Venus Xeon-Blonde <venus@cloudflare.com>
Signed-off-by: Venus Xeon-Blonde <venus@cloudflare.com>
Signed-off-by: Venus Xeon-Blonde <venus@cloudflare.com>
Author
|
I can close this one too I think once the changes from vbpf/prevail#1070 make it over here (and perhaps the crate gets a new release) |
Owner
|
With v0.2.1 ported, I think this can be closed |
Author
|
Looks good! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust does not support build-time definitions in the same way used in vbpf/prevail#1060, so we instead make those constants into global statics, which may be initialized once before any other library functions are called (otherwise they'll use the existing defaults).
All references to those constants have been updated to use the statics, which unfortunately means that the implementation of crab/bitset_domain.rs is no longer constant size, and now uses
Vecs.