Conversation
jhorbulyk
suggested changes
Sep 2, 2021
jhorbulyk
suggested changes
Sep 8, 2021
Contributor
jhorbulyk
left a comment
jhorbulyk
left a comment
There was a problem hiding this comment.
Didn't review fully but it looks like component.json changes are missing as well as application of style rules.
…/splitter-component into timeout_implementation
jhorbulyk
suggested changes
Sep 10, 2021
Contributor
|
My biggest question: #72 (comment) |
jhorbulyk
suggested changes
Sep 15, 2021
jhorbulyk
reviewed
Sep 16, 2021
| } | ||
|
|
||
| async function processAction(msg, cfg) { | ||
| const { mode } = cfg; |
Contributor
There was a problem hiding this comment.
Suggested change
| const { mode } = cfg; | |
| const { mode = 'groupSize'} = cfg; |
One last change: We should default to having the mode be set to group size in order to ensure backwards compatibility.
jhorbulyk
approved these changes
Sep 16, 2021
Closed
This reverts commit f728e0a.
* Update CHANGELOG.md * Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added delay timer property in re-assemble action.