Fix binary build time returned by version command#13140
Merged
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @swiatekm? 🙏
|
e37a226 to
ff7e525
Compare
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @swiatekm |
ebeahan
approved these changes
Mar 13, 2026
Contributor
|
@Mergifyio backport 8.19 9.2 9.3 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
(cherry picked from commit 9265949)
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
(cherry picked from commit 9265949)
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
(cherry picked from commit 9265949)
6 tasks
ebeahan
pushed a commit
that referenced
this pull request
Mar 13, 2026
ebeahan
pushed a commit
that referenced
this pull request
Mar 13, 2026
ebeahan
pushed a commit
that referenced
this pull request
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where the build time reported by the agent binary is the zero value. This was accidentally broken by #12856, where the global containing this value was moved to the Settings struct, but was never actually populated.
I've also added unit tests and verified that the output of
versionis correct in an existing integration test.Why is it important?
The reported build time should be accurate.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolHow to test this PR locally
Build the agent and run
elastic-agent version --binary-only. Packaging isn't necessary.