fix(cli): allow --help to work without config file#3927
Open
littleKitchen wants to merge 1 commit intoelastic:mainfrom
Open
fix(cli): allow --help to work without config file#3927littleKitchen wants to merge 1 commit intoelastic:mainfrom
littleKitchen wants to merge 1 commit intoelastic:mainfrom
Conversation
The CLI now allows running --help on subcommands (connector, index, job) without requiring authentication first. Previously, users would see a confusing error about config.yml not being found. Changes: - Skip config loading when help flags (-h/--help) are present - Update error message to suggest running 'connectors login' first - Add tests verifying help works without config Fixes elastic#3700
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
Member
|
Hi @littleKitchen, Thanks for your contribution! I will test it out, but can you in the meantime sign the Elastic CLA, so that we could proceed with merging this change in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running
connectors <subcommand> --helpwithout first runningconnectors login, users would see a confusing error aboutconfig.ymlnot being found. This PR fixes that by allowing help to work without authentication.Changes
-h/--help) are present in command argsconnectors loginfirst (clearer guidance)Testing
Before
After
Fixes #3700