Preserve duplicate Cassandra list values#327
Open
dipeshbabu wants to merge 3 commits into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
=========================================
Coverage ? 70.74%
=========================================
Files ? 21
Lines ? 2796
Branches ? 0
=========================================
Hits ? 1978
Misses ? 818
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dipeshbabu
force-pushed
the
agent/preserve-cassandra-duplicates
branch
from
July 22, 2026 05:39
13be921 to
65f4769
Compare
dipeshbabu
force-pushed
the
agent/preserve-cassandra-duplicates
branch
from
July 22, 2026 05:49
65f4769 to
df2acb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Include the monotonic timestamp in the Cassandra clustering key, keep set inserts idempotent with a fixed timestamp, validate existing table schemas, and add duplicate/removal integration regressions.
Why
The previous primary key used only key and value, so repeated ordered values overwrote each other. An empty MinHash repeats the same band hash, which meant its key metadata lost bands and removal left stale bucket entries.
Impact
Cassandra ordered storage now preserves every inserted value while unordered bucket storage remains deduplicated. Tables created with the old primary key fail with a clear rebuild instruction instead of silently retaining unsafe semantics.
Root cause
The ordering timestamp was a regular column rather than part of row identity.
Checks