Return [] (not None) from empty-input chunk helpers#5
Open
shaunpatterson wants to merge 1 commit into
Open
Conversation
find_chunks_start_and_end and repair_gaps_between_chunks returned None on empty input despite a list[...] return hint. Callers zip/iterate the result, so an empty document could raise TypeError instead of degrading gracefully. Return [] and tighten repair_gaps_between_chunks's hint to list[str]. Adds empty-input regression tests for both. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (Major, robustness)
find_chunks_start_and_end(hintedlist[tuple[int, int]]) andrepair_gaps_between_chunks(hintedlist[str] | None) both returnedNoneon empty input. Callerszip/iterate the result, so an empty document could raiseTypeErrorrather than degrading gracefully — and theNonecontradicts the type hint.Fix
Return
[]from both on empty input, and tightenrepair_gaps_between_chunks's return type tolist[str]. Behavior on non-empty input is unchanged.Tests
Added empty-input regression tests asserting
[]for both helpers.🤖 Generated with Claude Code