Add initial support for simplified hover type information#230
Add initial support for simplified hover type information#230aosen-xiong wants to merge 25 commits intoeisopux:masterfrom
Conversation
|
The type message looks like this now: |
|
@wmdietl Hi Werner, I have complete the feature of simpler type hover information. Please review it. I am not sure why I can request review or assign you directly. |
wmdietl
left a comment
wmdietl
left a comment
There was a problem hiding this comment.
These hovers look much nicer!
Can you fix the CI failures and look at me initial comments?
| public class CheckerTypeKind { | ||
| private String checkername; | ||
|
|
||
| private Map<String, String> TypeKind; |
There was a problem hiding this comment.
What is this mapping from/to?
Field names should start lower case.
There was a problem hiding this comment.
The map stores type information in the key of the map and type kind information e.g. used/declared in the value of the map.
| for (CheckerTypeKind checkerTypeKind : checkerTypeKinds) { | ||
| if (checkerTypeKind.getCheckername().equals(checker)) { | ||
| foundChecker = true; | ||
| if (!checkerTypeKind.getTypeKind().containsKey(type)) { |
There was a problem hiding this comment.
These methods have a very deep nesting level. Can you try to split off smaller helper methods? Or at least add some comments to make the flow understandable?
There was a problem hiding this comment.
already refactored and added comment.
2 participants
Now it looks like this, still working on more features.
I will rebase this PR to #238