Skip to content

Only reset the visitedNodes if they are not empty #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmdietl merged 1 commit into from
Apr 21, 2026
+3 −1
Merged

Only reset the visitedNodes if they are not empty #1646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ework/src/main/java/org/checkerframework/framework/type/visitor/AnnotatedTypeScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ public void reset() {
// Instead of re-using the same visitedNodes instance and clear-ing it, profiling showed it
// to be more efficient to create a new instance.
// visitedNodes.clear();
visitedNodes = new IdentityHashMap<>();
if (!visitedNodes.isEmpty()) {
visitedNodes = new IdentityHashMap<>();
}
Comment on lines 174 to +179
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above reset() says profiling showed it is more efficient to create a new visitedNodes instance, but the new logic only does so when the map is non-empty. Please update the comment to reflect the conditional behavior (or adjust the code to match the comment), otherwise it becomes misleading for future maintainers.

Copilot uses AI. Check for mistakes.
}

/**
Expand Down
Loading